datamatrix: Macro 05/06 always in first position - #313
Merged
Conversation
The Data Matrix encoder was fixed to emit the Macro 05/06 codeword as the first codeword. The old behaviour could cause latch/unlatch before Macro 05/06: however these must be in the first position.
Member
|
LGTM. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Data Matrix encoder was fixed to emit the Macro 05/06 codeword as the first codeword. The old behaviour could cause latch/unlatch before Macro 05/06: however these must be in the first position. (with my scanner, the Format 06 stuff was getting missed off. annoyingly, zxing seems to include it anyway...)
NB: The code herein is AI generated: I've never even read postscript before. That said, the change is fairly small and looks fine to me. Tested before and after to make sure everything still works and verify there is a problem that the fix fixes.