fix: re-enable Go strings test #1653 - #1687
Open
RuchitRathi wants to merge 1 commit into
Open
Conversation
The Go bindings test for string handling was disabled in PR bytecodealliance#1651 when async tests were reorganized. The test files were moved to tests/runtime/strings/disabled/ but the test infrastructure only discovers test files in the main directory. Test discovery in crates/test/src/lib.rs walks through test directories looking for language-specific test files (test.go, runner.go, etc.) in the same directory as the test.wit file. Files in subdirectories are not discovered. The Go strings test was not async-related and should not have been disabled. It was collaterally affected when PR bytecodealliance#1651 disabled multiple tests. This change moves the Go test files back to the main strings directory where they can be discovered and executed: - tests/runtime/strings/disabled/test.go → tests/runtime/strings/test.go - tests/runtime/strings/disabled/runner.go → tests/runtime/strings/runner.go The test files are valid and require no modifications. They test: - Basic Latin UTF-16 string handling - Unicode emoji and extended characters - Empty strings - String roundtrip operations Fixes: bytecodealliance#1653
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go bindings test for string handling was disabled in PR #1651 when async tests were reorganized. The test files were moved to tests/runtime/strings/disabled/ but the test infrastructure only discovers test files in the main directory.
Test discovery in crates/test/src/lib.rs walks through test directories looking for language-specific test files (test.go, runner.go, etc.) in the same directory as the test.wit file. Files in subdirectories are not discovered.
The Go strings test was not async-related and should not have been disabled. It was collaterally affected when PR #1651 disabled multiple tests.
This change moves the Go test files back to the main strings directory where they can be discovered and executed:
The test files are valid and require no modifications. They test:
Fixes: #1653