Repository navigation
Don't cancel spawned rust tasks on component task cancel - #1743
Merged
alexcrichton merged 2 commits intoOct 13, 2026
Merged
Conversation
This commit updates the handling of `EVENT_CANCEL` to signal cancellation for the "root task" but nothing else. This differs from before where now spawned Rust tasks will continue executing to completion as they otherwise would, meaning that `EVENT_CANCEL` is only for the root computation not the entire set of tasks.
alexcrichton
force-pushed
the
only-cancel-root
branch
from
October 12, 2026 16:31
21aa37b to
59c6fc5
Compare
6 tasks
pchickey
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the handling of
EVENT_CANCELto signal cancellation for the "root task" but nothing else. This differs from before where now spawned Rust tasks will continue executing to completion as they otherwise would, meaning thatEVENT_CANCELis only for the root computation not the entire set of tasks.