Repository navigation
Handle wasip3 task-specific information differently - #1752
Open
alexcrichton wants to merge 1 commit into
Open
alexcrichton wants to merge 1 commit into
alexcrichton wants to merge 1 commit into
Conversation
This commit is the dual of WebAssembly/wasi-libc#884 to handle the changes happening there. Specifically on wasip3 using TLS is going to stop working in wasi-sdk once that wasi-libc PR lands. The rationale for this is that TLS wants to be the same across all component model tasks, not unique per-task. This change detects whether wasi-sdk-35 or later is in use and invokes the wasi-libc-defined API in that situation. This means that wit-bindgen will continue to work as-is with wasi-sdk-34 and after this commit it'll additionally be compatible with wasi-sdk-35 as well. Eventually in the future wasi-sdk-35 can be unconditionally required at which point the C shims here can go away entirely.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the dual of WebAssembly/wasi-libc#884 to handle the changes happening there. Specifically on wasip3 using TLS is going to stop working in wasi-sdk once that wasi-libc PR lands. The rationale for this is that TLS wants to be the same across all component model tasks, not unique per-task. This change detects whether wasi-sdk-35 or later is in use and invokes the wasi-libc-defined API in that situation. This means that wit-bindgen will continue to work as-is with wasi-sdk-34 and after this commit it'll additionally be compatible with wasi-sdk-35 as well. Eventually in the future wasi-sdk-35 can be unconditionally required at which point the C shims here can go away entirely.