Repository navigation
test: cover .cat --follow and .last --follow disconnect cleanup - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds disconnect-cleanup coverage for
.cat --followand.last --follow, the gap called out in #55.cross-stream 0.14.1 (
dff9662) fixed the follow loops to observe the caller's interrupt, so a disconnected SSE client no longer parks a thread until the next matching frame. http-nu already depends on 0.14.1 (since v0.18.0), but nothing tested the follow case.Changes
test_bus_sub_released_when_client_disconnectsinto a shared helperassert_streams_released_on_disconnect.test_cat_follow_released_when_client_disconnectsandtest_last_follow_released_when_client_disconnects, each running a store-backed server whose handler follows a topic nothing writes to.Verification
.cat --followand.last --follow.scripts/check.shpasses.Closes #55.