Skip to content

fix: first line hunks#14

Merged
cachebag merged 2 commits into
cachebag:masterfrom
LOTaher:fix/first-line-hunks
May 21, 2026
Merged

fix: first line hunks#14
cachebag merged 2 commits into
cachebag:masterfrom
LOTaher:fix/first-line-hunks

Conversation

@LOTaher

@LOTaher LOTaher commented May 21, 2026

Copy link
Copy Markdown
Collaborator

One line change. As discussed in #5, probably not the most ideal way to handle this. Happy to iterate and discuss more.

@LOTaher

LOTaher commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

There is also a world where we prepend text to a hunk running into this case saying "(Line 1)" or something along those lines. Not too sure how I feel about that though. Need to think about it more.

@cachebag cachebag left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this LGTM i don't like it as a silver bullet but its better than invisible hunks

Comment thread lua/jumpy/render.lua
@cachebag

Copy link
Copy Markdown
Owner

There is also a world where we prepend text to a hunk running into this case saying "(Line 1)" or something along those lines. Not too sure how I feel about that though. Need to think about it more.

yeah honestly i dont really like that, the core issue is still apparent and i feel like doing this is just annoying.

@LOTaher

LOTaher commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Ah wait, running into a little problem on reprompts still:

image

Can get to this later tonight.

@cachebag

cachebag commented May 21, 2026

Copy link
Copy Markdown
Owner

Ah wait, running into a little problem on reprompts still:
image

Can get to this later tonight.

your branch just needs a rebase off master. This should have been fixed in #10 so no worries

@cachebag cachebag merged commit 19eb5b6 into cachebag:master May 21, 2026
3 checks passed
@LOTaher

LOTaher commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Oh fire. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants