Conversation
…est fixture #2618 removed `installArgs` from `AndroidSnapshotHelperManifest` and updated the shared helper fixture, the packaging script and the parse test, but this file kept its own hand-written manifest literal with the field still in it, which is what `tsc` rejects on main today's tip: an excess property on a type that no longer declares it. A second copy of the manifest is also how that field survived this long. Both tests re-hash the manifest for the APK they write, so the identity fields carry no test intent; they now come from `ANDROID_SNAPSHOT_HELPER_FIXTURE_ARTIFACT` like every other helper test. The one case that still needs a manifest carrying `installArgs` is the parse path that ignores it, and that case spells the key out inline in `snapshot-helper.test.ts`.
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Closed: #2625 landed the same fix on main ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm typecheckis red onmainat2cafab3ad0, so Typecheck & Package fails for every open PR. #2618 removedinstallArgsfromAndroidSnapshotHelperManifestand updated the shared helper fixture, the packaging script and the parse test — butsnapshot-helper-install.test.tskept a second hand-written manifest literal with the field still in it, which is an excess property on a type that no longer declares it.Both tests in that file re-hash the manifest for the APK they write, so the identity fields carried no test intent. They now come from
ANDROID_SNAPSHOT_HELPER_FIXTURE_ARTIFACTthe way every other helper test reads it, which is also the reason a second copy cannot drift from the type again. The one case that needs a manifest carryinginstallArgsis the parse path that ignores it, and that case already spells the key inline insnapshot-helper.test.ts:913.One file, +4/-15, test-only. This unblocks the gate for the open PRs, including #2607 and #2610.
Validation
Tested at
f737dee6c6.pnpm check:affected --rungreen:format:check,lint,tsc -bacross all 24 projects (the check that is red onmain),check:layering,check:fallow --base origin/main,vitest related.snapshot-helper-install.test.tsandsnapshot-helper.test.ts: 26 tests passed.