Repository navigation
Conversation
…ice, true comments (#372) Review round 2 fixes: holdsState fails on any poll that leaves the state; test 1 holds one ready device per platform for a window; test 3 asserts the second lease gets the first round's device and that its lease.granted event exists; the HOLD comment names one pool tick. 4 findings -> 0
Comment-only; no test count changes (0 failing -> 0 failing)
…its kind (#372) The planner boots the first shutdown device that serves the request, not the one just released. 1 failing -> 1 failing (slow lane, not run here)
… device is the only one the next lease can boot (#372) The second lease asserts the released device's id. 1 failing -> 1 failing (slow lane, not run here)
…gy (#372) Round 6 finding: the lane's snapshot-restore claim could stay green on a wipe fallback. Test 2 now asserts device.reclaimed strategy is snapshot; two comments reworded.
…get and names itself (#372) The 30 min timeout named no step: the log showed no progress and unbounded calls (list, simctl, adb) could not fail alone. Each step is bounded, logged, and a failure dumps the daemon log tail and the device rows.
…lines reach the log (#372) Fix round 8: every question put to the machine or daemon has a timeout, the test timeouts exceed budgets plus unbudgeted work, test 3's daemon start is a named step inside the try, and the slow lane runs the default reporter so a passing test's console lines reach the log. 4 findings -> 0 open
#372) Keeps the test body under the Fallow complexity threshold. 1 failing -> 0 failing
…as (#372) claims-only: 0 failing -> 0 failing
Hardware postponedThe review passed at 8d62bbc, with no blocking findings after round 10. The slow-lane check still has to run.
Next: run An emulator (qemu, pid 53897) was still running after the stop. It may come from run 3, but that is not proven, so it was left alone. Written by an agent. |
Hardware: passedRan
Not shown: the skip-when-a-platform-is-missing case, because this machine has both platforms. Issue #372 and its parent #359 are closed. This PR is still a draft; its Done when boxes and gate are for the maintainer. Written by an agent. |
Closes #372
Status
Implement: done (slow-lane tests only) Review: round 10, 0 open Mutate: n/a (no src change) Hardware: passed on 8d62bbc (3 of 3, slow lane, 2026-10-10) Gate: pending
Done when
scripts/slow-e2e.shrunse2e/slow-warm-pool.test.tsgreen, and its log names the twodevice.readyevents before the first lease.Review
Review passed at 8d62bbc after round 10 with no blocking finding open. No finding was overruled.
Assumptions
docs/internal/ARCHITECTURE.mdtest-lanes paragraph — that file has no test-lanes paragraph; the lane docs live ine2e/README.md, so its known-gaps line about real emulators now names the new file there.scripts/slow-e2e.shby being passed as its argument (the script runs whatever files it is given; it lists none).Written by an agent.