Update dependency typescript to v7 - #32
Open
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit into
Open
Update dependency typescript to v7#32red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit into
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps the TypeScript compiler dependency from 5.6.x to 7.0.x in the dashboard project so it can use the newer TypeScript toolchain, with corresponding lockfile updates. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this is a major TypeScript upgrade, verify that your
tsconfig.json(e.g.,target,module,moduleResolution, and strictness flags) is still aligned with the new defaults and doesn’t rely on deprecated/changed compiler options between 5.x and 7.x. - Check that any tooling tightly coupled to TypeScript’s API or version (ESLint TypeScript parser, custom transformers, ts-node, vite plugins, etc.) is compatible with v7 to avoid subtle build or type-checking issues after the upgrade.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this is a major TypeScript upgrade, verify that your `tsconfig.json` (e.g., `target`, `module`, `moduleResolution`, and strictness flags) is still aligned with the new defaults and doesn’t rely on deprecated/changed compiler options between 5.x and 7.x.
- Check that any tooling tightly coupled to TypeScript’s API or version (ESLint TypeScript parser, custom transformers, ts-node, vite plugins, etc.) is compatible with v7 to avoid subtle build or type-checking issues after the upgrade.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.6.0→^7.0.0Release Notes
microsoft/TypeScript (typescript)
v7.0.2Compare Source
v6.0.3: TypeScript 6.0.3Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
v6.0.2: TypeScript 6.0Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.