Skip to content

improve string-marker extraction - #1503

Merged
hrischuk-da merged 1 commit into
mainfrom
string-marker-extractor-hardening
Sep 1, 2026
Merged

improve string-marker extraction#1503
hrischuk-da merged 1 commit into
mainfrom
string-marker-extractor-hardening

Conversation

@danielporterda

@danielporterda danielporterda commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request

  1. preserves source indentation when extracting string-marker snippets and
  2. rejects missing, empty, or duplicate markers.

@danielporterda
Harden string marker extraction
16e81e3 
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This was referenced Aug 31, 2026
Merged
Closed
@danielporterda
danielporterda marked this pull request as ready for review September 1, 2026 01:59
@danielporterda danielporterda changed the title Harden string-marker extraction improv string-marker extraction Sep 1, 2026
@danielporterda danielporterda changed the title improv string-marker extraction improve string-marker extraction Sep 1, 2026
@hrischuk-da
hrischuk-da merged commit a903c80 into main Sep 1, 2026
3 checks passed
@hrischuk-da
hrischuk-da deleted the string-marker-extractor-hardening branch September 1, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrischuk-da hrischuk-da hrischuk-da approved these changes
@coldice coldice Awaiting requested review from coldice
@da-tanabe da-tanabe Awaiting requested review from da-tanabe

Assignees

@da-tanabe da-tanabe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielporterda @hrischuk-da @da-tanabe