Remove Commons Repo Workaround — Use Public npm for @sap/cds-dk and @sap/cds-mtxs - #594
Merged
Merged
Conversation
akgarg06
requested review from
PujaDeshmukh17,
vibhutikumar07 and
yashmeet29
as code owners
September 11, 2026 08:50
rashmiangadi05
approved these changes
Sep 11, 2026
vibhutikumar07
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Why
@sap/cds-mtxs@3.9.7and@sap/cds-dk@9.9.5(and later) are now published on public npm.The previous workaround used SAP's internal Artifactory commons tarball URLs injected at CI runtime via secrets (
SAP_CDS_MTXS_TARBALL,SAP_CDS_DK_TARBALL,NPM_AUTH_TOKEN) because these versions were not yet available publicly.That workaround is no longer needed and has been fully removed.
What Changed
Workflow files — removed the "Setup npm registry and pin SAP tarballs" step
All five workflows that had the secret-injecting tarball setup step have been cleaned up:
blackduck.ymlnpm install --legacy-peer-depsloopmultiTenancyDeployLocal.ymlmultiTenant_deploy_and_Integration_test.ymlmultiTenant_deploy_and_Integration_test_LatestVersion.ymlcfdeploy.ymlDeployandSnapshotDeployjobsThe secrets
SAP_CDS_MTXS_TARBALL,SAP_CDS_DK_TARBALL, andNPM_AUTH_TOKENare no longer referenced in any workflow.pom.xml— updatedcds.install-cdsdk.versionto^9Replaced all hardcoded exact version values with the range specifier
^9, consistent with how@sap/cds-mtxsis already declared (^3) in the Maven plugin install arguments.multi-tenant/central-space/.../pom.xml9.8.0^9multi-tenant/personal-space/.../pom.xml9.3.1^9single-tenant/central-space/demoapp/pom.xml8.0.2^9single-tenant/personal-space/demoapp/pom.xml8.0.2^9The
srv/pom.xmlinstall arguments already used@sap/cds-mtxs@^3and remain unchanged. Withcds.install-cdsdk.version=^9, the full install command becomes:package.jsonfiles — no change neededAll four multi-tenant
package.jsonfiles already declare"@sap/cds-dk": "^9"and"@sap/cds-mtxs": "^3". These are correct and unchanged.Type of change
Please delete options that are not relevant.
Checklist before requesting a review