Repository navigation
v5: memset MCInst on init. - #3032
Merged
Merged
Conversation
Since everybody figured out how to script an LLM vulnerability scanner, we get an annoying amount of "use of uninitialized memory" reports. MCInst is stack memory here, so I doubt this has an impact on performance.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Capstone’s internal MCInst initialization to fully zero-initialize the MCInst struct on creation, addressing a security advisory report related to TMS320 behavior.
Changes:
- Replace manual field-by-field initialization in
MCInst_Init()withmemset(inst, 0, sizeof(MCInst)). - Preserve the required non-zero default for
tied_op_idx[]by explicitly setting all entries to-1after the memset.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Addresses the report about TMS320 in GHSA-8qp8-2vg2-8mr4
Test plan
Locally
Closing issues
...