Repository navigation
v5: Handle case of vsprintf returning oob pointer offset. - #3061
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly added bounds check should be adjusted to avoid signed/unsigned comparison (and available - 1 underflow patterns) to prevent warnings or Werror build failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Backport of #3060 to harden SKIPDATA operand-string generation against abnormal vsnprintf/cs_snprintf return values that could otherwise lead to out-of-bounds pointer arithmetic.
Changes:
- Add an early error/length check after the initial
cs_snprintf()inskipdata_opstr()to prevent advancingp/ reducingavailableon invalid lengths.
File summaries
| File | Description |
|---|---|
| cs.c | Adds a guard for cs_snprintf return values to avoid OOB pointer/length updates when formatting SKIPDATA operand strings. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Backport of #3060
Test plan
...
Closing issues
...