Repository navigation
Fix/x86 x87 implicit access 2366 - #3132
Merged
Rot127 merged 2 commits intoOct 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3132 +/- ##
=======================================
Coverage ? 61.30%
=======================================
Files ? 243
Lines ? 56814
Branches ? 10075
=======================================
Hits ? 34827
Misses ? 16790
Partials ? 5197 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rot127
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fix missing implicit
ST(0)reads and writes for x87 arithmetic instructions. Correct destination operand access and reportFPSWwrites.Test plan
Added 6 regression cases covering 60 instructions, 16/32/64-bit modes, and intel/att syntax.
Closing issues
Closes #2366