Skip to content

Fix/x86 x87 implicit access 2366 - #3132

Merged
Rot127 merged 2 commits into
capstone-engine:nextfrom
raaller:fix/x86-x87-implicit-access-2366
Oct 20, 2026
Merged

Rot127 merged 2 commits into
capstone-engine:nextfrom
raaller:fix/x86-x87-implicit-access-2366

Conversation

@raaller

@raaller raaller commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fix missing implicit ST(0) reads and writes for x87 arithmetic instructions. Correct destination operand access and report FPSW writes.

Test plan

Added 6 regression cases covering 60 instructions, 16/32/64-bit modes, and intel/att syntax.

Closing issues

Closes #2366

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (next@d01f16f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3132   +/-   ##
=======================================
  Coverage        ?   61.30%           
=======================================
  Files           ?      243           
  Lines           ?    56814           
  Branches        ?    10075           
=======================================
  Hits            ?    34827           
  Misses          ?    16790           
  Partials        ?     5197           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rot127
Rot127 requested a balanced review from Copilot October 20, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Update the corresponding source metadata and regenerate the auto-generated mapping files.

No open issues 🎉

Review effort: Lite

@Rot127
Rot127 merged commit 4333798 into capstone-engine:next Oct 20, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

register accesses for Implicit operands

3 participants