Repository navigation
Add aria-valuetext to the seeking, volume and balance sliders - #1371
Merged
Merged
Conversation
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
|
Size Change: +210 B (+0.04%) Total Size: 490 kB 📦 View Changed
|
captbaritone
added a commit
that referenced
this pull request
Oct 15, 2026
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
captbaritone
added a commit
that referenced
this pull request
Oct 15, 2026
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
captbaritone
added a commit
that referenced
this pull request
Oct 15, 2026
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
captbaritone
added a commit
that referenced
this pull request
Oct 15, 2026
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
captbaritone
added a commit
that referenced
this pull request
Oct 15, 2026
Screen readers announced these range inputs as bare numbers (e.g. "26" for the seeking bar). Describe their values instead: - Seeking Bar: "0:32 of 2:00" (the scrub position while dragging) - Volume Bar: "75%" - Balance: "Center", "20% Left" or "20% Right"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1369 (keyboard seeking), since both touch
Position.tsx.The seeking, volume and balance sliders are native range inputs, so screen readers announce their raw value: the seeking bar reads as "26", which means nothing. This adds
aria-valuetext:The seeking bar's text uses
timeElapseddirectly rather than reconstructing it from the slider's percentage. That avoids floating-point error showing "0:31" for 32 seconds.The EQ band sliders get equivalent value text ("+6.0 dB") in #1370.
Testing
Position.test.tsxcases cover the text both idle ("0:30 of 2:00") and while scrubbing ("1:00 of 2:00").Balance.test.tscoversbalanceValueText.tsc,eslint,prettier --checkandvitest runpass locally.