Skip to content

Fix/dhd 3661 project update fixes - #120

Closed
pancysingla-creator wants to merge 6 commits into
mainfrom
fix/DHD-3661-project-update-fixes
Closed

pancysingla-creator wants to merge 6 commits into
mainfrom
fix/DHD-3661-project-update-fixes

Conversation

@pancysingla-creator

Copy link
Copy Markdown
Contributor

What

  • docker-compose.yaml: use bitnamilegacy/postgresql:14.5.0.
  • ci-pipeline.yml: set k3d-version: v5.6.0

pancysingla-creator and others added 4 commits November 13, 2026 13:27
Bitnami removed its versioned images from Docker Hub, so
bitnami/postgresql:14.5.0 no longer resolves and `make it-test-api`
fails at `docker compose up -d postgres`. The same image is still
published under bitnamilegacy/.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
k3d-action installs k3d through k3d's latest install.sh, which now also
downloads checksums.txt from the release. k3d v5.2.2 (the action's
default) never published that file, so the install failed with a 404.
v5.6.0 publishes it.

k3d v5.6.0 starts a newer k3s that no longer accepts --no-deploy, so
metrics-server is disabled with the equivalent --disable flag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The k3d registry at registry.localhost:5000 only serves plain HTTP.
Docker on the runner now tries HTTPS for that hostname and fails with
"server gave HTTP response to HTTPS client". Docker always allows plain
HTTP for loopback IPs, so push through 127.0.0.1:5000 instead. It is the
same registry, so the cluster still pulls from registry.localhost:5000.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The MLP chart depends on stable/postgresql 7.0.2, whose default image
bitnami/postgresql:11.5.0-debian-9-r84 is no longer on Docker Hub (and
was not copied to bitnamilegacy). The postgres pod cannot start, so
`helm install --wait` times out. Use bitnamilegacy/postgresql:11.22.0,
the latest Postgres 11 image that is still published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Projects whose labels are null (or omitted by the API) crashed the
Project Info confirm dialog on Submit with "Cannot read properties of
undefined (reading 'map')", so no PUT request was sent. Default both
the original and the edited labels to an empty list before mapping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the OnProjectUpdated webhook replies 404 "team not found", the
project update now fails with a 400 that names the team and asks the
user to change the stream and team, instead of a 500 with the raw
webhook response.

- Webhook client: 4xx replies return a ResponseError (status and the
  webhook's error message) and are no longer retried.
- UpdateProject: map the "team not found" reply to an
  InvalidArgumentError and log the correct event name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@anantadwi13 anantadwi13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pancysingla-creator thanks for your changes, but i have some questions below

Comment thread .github/workflows/ci-pipeline.yml Resolved
var respErr *webhooks.ResponseError
if errors.As(err, &respErr) &&
respErr.StatusCode == http.StatusNotFound &&
strings.Contains(strings.ToLower(respErr.Message), "team not found") {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of hardcoding the error message, what if we return the webhook error as well?
if we dont want to return the plain webhook error, we can just log the webhook error and return "error webhook" to the user (make sure there is a request id to track).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I’ll change it so any 4xx from a webhook comes back as a 400 with the webhook’s own message plus the project’s team and stream. I'll remove the string matching.

This branch was successfully deployed

1 active deployment
manual — 9a472669 Deployed Nov 13, 2026 by pancysingla-creator via publish-docker #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants