Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selected-dependencies example uses
tomli_w, which is not a declared extra, and therefore does not install the same TOML dependency as[all]. Usetomlto matchsetup.py, and documenttomlias the extra that installstomli-w.Quote the package specifications in all three shell commands so the brackets reach pip unchanged instead of being interpreted as filename patterns, including by zsh. The requirements.txt example remains unquoted. Added a changelog note and contributor entry as requested by CONTRIBUTING.rst; this targets
develop.Validation: inspected
setup.pyas an AST and confirmed the declared extras and their dependencies; read TOML backend selection inbox/converters.py; reviewed the exact documentation diff and source blob hashes. I did not install the package, execute setup.py, or run the project test suite. Runtime code is unchanged.AI assistance: prepared using OpenAI Codex and reviewed against the repository's source and contribution guide.