Repository navigation
Unwrap compat and parsed legacy list/map wrappers in FromLegacyList and FromLegacyMap, and avoid per-call scratch arenas in legacy map Has. - #2363
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_996898134
branch
from
October 13, 2026 15:02
a1fe92f to
876e4cf
Compare
… and `FromLegacyMap`, and avoid per-call scratch arenas in legacy map `Has`. 1. Add `FromLegacyList` and `FromLegacyMap` (used by `ModernValue` and `FromLegacyValue`) to unwrap `LegacyParsedRepeatedFieldListValue`, `LegacyParsedJsonListValue`, `CompatListValue`, and `MutableCompatListValue` (and their map counterparts `LegacyParsedMapFieldMapValue`, `LegacyParsedJsonMapValue`, `CompatMapValue`, and `MutableCompatMapValue`) back into `CustomListValue` / `CustomMapValue` using their owning arena instead of re-wrapping them in `LegacyListValue` / `LegacyMapValue`. 2. In `LegacyParsedMapFieldMapValue::Has(const CelValue&)` and `LegacyParsedJsonMapValue::Has(const CelValue&)`, use `arena_` instead of constructing a per-call `proto2::Arena scratch_arena`. PiperOrigin-RevId: 998661512
copybara-service
Bot
force-pushed
the
test_996898134
branch
from
October 13, 2026 15:43
876e4cf to
21a5734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unwrap compat and parsed legacy list/map wrappers in
FromLegacyListandFromLegacyMap, and avoid per-call scratch arenas in legacy mapHas.FromLegacyListandFromLegacyMap(used byModernValueandFromLegacyValue) to unwrapLegacyParsedRepeatedFieldListValue,LegacyParsedJsonListValue,CompatListValue, andMutableCompatListValue(and their map counterpartsLegacyParsedMapFieldMapValue,LegacyParsedJsonMapValue,CompatMapValue, andMutableCompatMapValue) back intoCustomListValue/CustomMapValueusing their owning arena instead of re-wrapping them inLegacyListValue/LegacyMapValue.LegacyParsedMapFieldMapValue::Has(const CelValue&)andLegacyParsedJsonMapValue::Has(const CelValue&), usearena_instead of constructing a per-callproto2::Arena scratch_arena.