Skip to content

Take cel::AttributeMatch by value #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 13, 2026
Merged

Take cel::AttributeMatch by value #2364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions base/attribute_matcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@ AttributeMatch MakeAttributeMatch(
const common_internal::AttributeMatcherNode* node);

[[nodiscard]]
const AttributeMatcherNode* GetAttributeMatcherNode(
const AttributeMatch& match);
const AttributeMatcherNode* GetAttributeMatcherNode(AttributeMatch match);

} // namespace common_internal

Expand Down Expand Up @@ -252,7 +251,7 @@ class [[nodiscard]] AttributeMatch {
friend AttributeMatch common_internal::MakeAttributeMatch(
const common_internal::AttributeMatcherNode* node);
friend const common_internal::AttributeMatcherNode*
common_internal::GetAttributeMatcherNode(const AttributeMatch& match);
common_internal::GetAttributeMatcherNode(AttributeMatch match);

AttributeMatch NotNoneMatchQualifier(
const AttributeQualifierView& qualifier) const {
Expand All @@ -276,7 +275,7 @@ inline AttributeMatch MakeAttributeMatch(

[[nodiscard]]
inline const AttributeMatcherNode* GetAttributeMatcherNode(
const AttributeMatch& match) {
AttributeMatch match) {
return match.node_;
}

Expand Down
Loading