Skip to content

Remove deprecated strong enum and unbound function runtime error conformance tests. #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated strong enum and unbound function runtime error conformance tests. #2365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions conformance/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@ _TESTS_TO_SKIP = [
# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",

# Future features for CEL 1.0
# TODO(issues/119): Strong typing support for enums, specified but not implemented.
"enums/strong_proto2",
"enums/strong_proto3",

# These depend on legacy US/ timezones. It's spotty if these are included with a normally
# configured timezone database.
"timestamps/timestamp_selectors_tz/getDayOfMonth_name_pos",
Expand All @@ -208,12 +203,7 @@ _TESTS_TO_SKIP_PARSE_ONLY = [

_TESTS_TO_SKIP_MODERN = _TESTS_TO_SKIP

_TESTS_TO_SKIP_MODERN_DASHBOARD = [
# Future features for CEL 1.0
# TODO(issues/119): Strong typing support for enums, specified but not implemented.
"enums/strong_proto2",
"enums/strong_proto3",
]
_TESTS_TO_SKIP_MODERN_DASHBOARD = []

_TESTS_TO_SKIP_LEGACY = _TESTS_TO_SKIP + [
# Legacy value does not support optional_type.
Expand All @@ -236,11 +226,6 @@ _TESTS_TO_SKIP_LEGACY = _TESTS_TO_SKIP + [
]

_TESTS_TO_SKIP_LEGACY_DASHBOARD = [
# Future features for CEL 1.0
# TODO(issues/119): Strong typing support for enums, specified but not implemented.
"enums/strong_proto2",
"enums/strong_proto3",

# Legacy value does not support optional_type.
"optionals/optionals",
]
Expand Down
Loading