Repository navigation
Report non-bool operands of logical operators as type mismatches. - #1382
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1002989610
branch
14 times, most recently
from
October 22, 2026 08:57
9600c73 to
e8d4024
Compare
When an operand of `&&` or `||` isn't a bool, the type-checker reports that no overload matches, e.g. `found no matching overload for '_&&_' applied to '(bool, int)'`. This is especially confusing for the `all` and `exists` macros: their predicates are expanded into these operators, which don't appear in the expression, and the error doesn't point at the predicate. PiperOrigin-RevId: 1004614536
copybara-service
Bot
force-pushed
the
test_1002989610
branch
from
October 22, 2026 09:33
e8d4024 to
9f35821
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report non-bool operands of logical operators as type mismatches.
When an operand of
&&or||isn't a bool, the type-checker reports that no overload matches, e.g.found no matching overload for '_&&_' applied to '(bool, int)'. This is especially confusing for theallandexistsmacros: their predicates are expanded into these operators, which don't appear in the expression, and the error doesn't point at the predicate.