Skip to content

Expose the verifier's counterexamples as structured CelWitness values #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+2,382 −1,754
Open

Expose the verifier's counterexamples as structured CelWitness values #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions verifier/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ public class PolicyVerifierExample {
System.out.println(result.message());
// Output:
// Equivalence violation detected. Counterexample input:
// country = "a"
// role = "editor"
// country = "a"
// port = 443
break;
case INCONCLUSIVE:
Expand All @@ -241,7 +241,8 @@ public class PolicyVerifierExample {
When checking whether an expression is satisfiable using `isSatisfiable`, the
verifier returns `VERIFIED` if there exists at least one input combination
where the expression evaluates to `true`. Furthermore, `result.message()`
provides concrete satisfying model assignments (witness/test case generation).
provides concrete satisfying model assignments (witness/test case generation),
and `result.witness()` exposes them as CEL runtime values.

```java
import dev.cel.common.CelAbstractSyntaxTree;
Expand Down
14 changes: 13 additions & 1 deletion verifier/src/main/java/dev/cel/verifier/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ java_library(
"CelVerificationResult.java",
"CelVerifier.java",
"CelVerifierBuilder.java",
"CelWitness.java",
],
tags = [
],
Expand All @@ -23,6 +24,7 @@ java_library(
"//common:cel_ast",
"//common/types:type_providers",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
],
)

Expand Down Expand Up @@ -112,7 +114,10 @@ java_library(

java_library(
name = "type_system",
srcs = ["CelZ3TypeSystem.java"],
srcs = [
"CelZ3Exprs.java",
"CelZ3TypeSystem.java",
],
compatible_with = [],
tags = [
],
Expand Down Expand Up @@ -157,10 +162,14 @@ java_library(
"CelAstAlphaHasher.java",
"CelAstToZ3Translator.java",
"CelVerifierZ3Impl.java",
"CelZ3ComprehensionTranslator.java",
"CelZ3CounterexampleGenerator.java",
"CelZ3ExtensionalityAxioms.java",
"CelZ3FunctionRegistry.java",
"CelZ3OperatorTranslator.java",
"CelZ3StructTranslator.java",
"CelZ3TranslationContext.java",
"CelZ3TypeConstraintGenerator.java",
"TranslatedValue.java",
],
compatible_with = [],
Expand All @@ -179,10 +188,13 @@ java_library(
"//common/ast",
"//common/ast:cel_block",
"//common/internal:cel_descriptor_pools",
"//common/internal:proto_time_utils",
"//common/internal:well_known_proto",
"//common/types",
"//common/types:cel_types",
"//common/types:type_providers",
"//common/values",
"//common/values:cel_byte_string",
"//optimizer",
"//optimizer:optimization_exception",
"//optimizer:optimizer_builder",
Expand Down
Loading
Loading