Repository navigation
Conversation
Each extension statically links protobuf, abseil and cel-cpp. On macOS, pybind_extension links with only `-undefined dynamic_lookup`, so those copies are exported, including thousands of weak definitions. dyld coalesces exported weak definitions across every loaded image, so importing cel_expr_python alongside another extension that ships protobuf (e.g. ortools) binds one runtime's code to the other's parse tables and crashes in AddDescriptors at import time. Wrap pybind_extension to add `-Wl,-exported_symbol,_PyInit_<name>` on macOS, matching the isolation Linux already gets from `-Wl,-Bsymbolic`, and add a macOS test that each extension exports only its init function. Fixes cel-expr#115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each extension statically links protobuf, abseil and cel-cpp. On macOS, pybind_extension links with only
-undefined dynamic_lookup, so those copies are exported, including thousands of weak definitions. dyld coalesces exported weak definitions across every loaded image, so importing cel_expr_python alongside another extension that ships protobuf (e.g. ortools) binds one runtime's code to the other's parse tables and crashes in AddDescriptors at import time.Wrap pybind_extension to add
-Wl,-exported_symbol,_PyInit_<name>on macOS, matching the isolation Linux already gets from-Wl,-Bsymbolic, and add a macOS test that each extension exports only its init function.Fixes #115