fix(devbase): correct the shipped description, and move this frame to devbase:2 - #14
Merged
Conversation
2.0.0 removed claude-code from dependsOn but left the manifest's own `description` still advertising it: "Pulls in Node LTS (which also provides pnpm), the GitHub CLI and Claude Code as dependencies". That string is published with the artifact and is folded into the generated feature README, so 2.0.0 shipped metadata contradicting its own behaviour. Filed as `fix` rather than `docs` deliberately. The description lives in the published manifest, so only a releasing commit type can correct what the registry serves — a `docs` commit would leave the wrong text in place until some unrelated release happened to carry it. Refs RSRMID-3053.
Completes the dogfooding loop: 2.0.0 is published, so this frame stops expecting the Claude Code CLI. The reference moves to `:2` and the lock re-resolves — devbase 2.0.0, and no claude-code entry, which is what actually proves the dependency is gone rather than merely unreferenced. The lock had to be re-resolved by hand, as always: `devcontainer upgrade` only fills in missing entries, so the devbase entry is deleted first and then re-resolved. Dependabot raises nothing here either, because a moving-tag reference has no version to bump. Comments corrected in the same pass — the frame claimed node, github-cli and claude-code all came from `dependsOn`, and told the reader this frame "still references devbase:1", both of which stopped being true one commit ago. Note the local/ frame needs no lock change: it builds ./devbase from the working tree, which is not a registry coordinate and so is not locked. Refs RSRMID-3053.
Contributor
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RSRMID-3053. Two commits, and the first is a defect 2.0.0 itself shipped.
fix(devbase): the description still advertised Claude Code2.0.0 removed
claude-codefromdependsOnbut left the manifest's owndescriptionreading "Pulls in Node LTS (which also provides pnpm), the GitHub CLI and Claude Code as dependencies". That string is published with the artifact and folded into the generated feature README, so 2.0.0 shipped metadata contradicting its own behaviour. My miss in #13 — the field is nowhere neardependsOnand I did not sweep for it.Filed as
fixrather thandocsdeliberately: the description lives in the published manifest, so only a releasing type corrects what the registry serves. Adocscommit would leave the wrong text there until some unrelated release happened to carry it. This will cut 2.0.1.ci(devcontainer): move this frame to devbase:2Completes the dogfooding loop. The rule here is that the frame stops expecting something only after the release that stops providing it — 2.0.0 is published, so the reference moves now.
The lock re-resolves to devbase 2.0.0 with no
claude-codeentry, which is what actually proves the dependency is gone rather than merely unreferenced. It had to be re-resolved by hand, as always: the devbase entry is deleted first, becausedevcontainer upgradeonly fills in missing entries, and Dependabot raises nothing for a moving-tag reference.Two comment corrections: the frame claimed node, github-cli and claude-code all came from
dependsOn, and told the reader this frame "still referencesdevbase:1" — true when I wrote it one commit earlier, false now.local/devcontainer.jsonneeds no lock change: it builds./devbasefrom the working tree, which is not a registry coordinate and so is not locked.Ordering note
The lock pins 2.0.0, not the 2.0.1 this PR will produce — 2.0.1 does not exist until this merges. That is the normal steady state here and needs no follow-up: a lock stays where it is until someone re-resolves it deliberately.