build(devcontainer): migrate onto the shared devbase Feature - #359
Merged
Conversation
The zsh prompt configuration, commitizen setup, pnpm bootstrap, shell history symlink and the common CLI packages now come from the devbase Feature, which also brings Node LTS, the GitHub CLI and the Claude Code CLI as its own dependencies. post-create.sh did all of that by hand — cloning powerlevel10k and zsh-autosuggestions on every create — and is gone. The JDK moves out of the language image and into the java Feature at 21, the LTS the image supplied; pom.xml still compiles to 17, so the runtime is deliberately ahead of the language level. Maven comes with it. devcontainer-lock.json is deleted rather than edited: it pinned the node, git and java Features as the frame declared them before. The first rebuild resolves a fresh one, which should then be committed. RSRMID-3019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RSRMID-3019 — the last six repositories still carrying a hand-maintained devcontainer move onto the shared
devbaseFeature, as php-sdk did in RSRMID-2976.What moves out
post-create.shcloned powerlevel10k and zsh-autosuggestions on every container create, copied in.zshrc/.p10k.zsh, and installed pnpm and commitizen by hand. All of that isdevbase's job now, and the script is gone. Node LTS, the GitHub CLI and the Claude Code CLI aredevbase's own dependencies, so this frame declares none of them.What stays
The JDK moves out of the language image and into the
javaFeature at 21 — the LTS thedevcontainers/javaimage supplied — with Maven.pom.xmlstill compiles to 17, so the runtime is deliberately ahead of the language level; say the word if the CI matrix wants a different major.Everything else left in
devcontainer.jsonis what a Feature cannot set: the workspace paths, the remote user,initializeCommandand the host mounts.~/.ssh,~/.gitconfigand~/.claudeare new alongside the/WSL_USERmount that was already there.Note on the lock file
devcontainer-lock.jsonis deleted rather than edited — it pinned thenode,gitandjavaFeatures as the old frame declared them. The first rebuild resolves a fresh one; please commit it afterwards.Verification
Not rebuilt yet — no Docker daemon in the workspace this was prepared from. Before merging, rebuild and check: the prompt renders,
devbase-env-inforeports the JDK, Maven and Node,cz --versionworks,git pushauthenticates throughgh, andmvn testruns.🤖 Generated with Claude Code