Repository navigation
CFE-4188: Removed requests python dependency in cf-bottom - #119
Merged
Merged
Conversation
victormlg
force-pushed
the
remove-requests-dep
branch
from
March 31, 2026 11:37
d6816fa to
c5245fb
Compare
Collaborator
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
victormlg
force-pushed
the
remove-requests-dep
branch
2 times, most recently
from
June 2, 2026 12:25
3aaa07c to
2b588d3
Compare
larsewi
approved these changes
Jun 3, 2026
Ticket: CFE-4188 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
remove-requests-dep
branch
from
June 3, 2026 10:50
2b588d3 to
db10aad
Compare
olehermanse
pushed a commit
that referenced
this pull request
Oct 16, 2026
Introduced in #119, which replaced requests with a Response class that has no ok attribute. Check status_code instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
olehermanse
pushed a commit
that referenced
this pull request
Oct 16, 2026
Introduced in #119. Callers expecting the error JSON crashed on an empty body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.