Skip to content

Fixed packages_mapping command in cf-bottom #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 2 commits into from
Oct 16, 2026
Merged

Fixed packages_mapping command in cf-bottom #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121f0c6
Fixed packages_mapping crash on missing Response.ok
larsewi Oct 16, 2026
5d76c4e
Fixed error response body being dropped on HTTP errors
larsewi Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tom/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ def _handle_request(
result.headers = r.headers
except HTTPError as e:
result.status_code = e.code
result.text = e.read().decode("utf-8")
result.headers = e.headers

return result

Expand Down
4 changes: 2 additions & 2 deletions tom/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def run(self, inputs):
"https://cfengine.com/release-data/%s/releases.json" % product
)
releases_request = network.get(releases_url)
if not releases_request.ok:
if releases_request.status_code != 200:
raise URLDownloadFailureException(
"failed to download %s, return code %d"
% (releases_url, releases_request.status_code)
Expand Down Expand Up @@ -234,7 +234,7 @@ def run(self, inputs):
def collect_packages(self, url):
"""Given a release URL, returns a dict where keys are platform names, and values are {'url': 'http...'}"""
release_request = network.get(url)
if not release_request.ok:
if release_request.status_code != 200:
raise URLDownloadFailureException(
"failed to download %s, return code %d"
% (url, release_request.status_code)
Expand Down
Loading