Repository navigation
Fixed --simulate=diff to report permission and ownership changes - #6436
Open
nickanderson wants to merge 1 commit into
Open
nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
Member
Author
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14869/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14869/ |
The diff report only ran 'diff -u' on file contents, so a file whose mode, owner or group changed without its contents was listed with nothing under it. Permission, owner and group changes are now printed before the content diff. Ticket: ENT-14694 Changelog: Title
nickanderson
force-pushed
the
ENT-14694/master
branch
from
October 25, 2026 15:06
ebc01f0 to
9673b77
Compare
Member
Author
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14870/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14870/ |
larsewi
approved these changes
Oct 26, 2026
| char name[CF_SMALLBUF]; | ||
| if (GetUserName(uid, name, sizeof(name), LOG_LEVEL_VERBOSE)) | ||
| { | ||
| snprintf(buf, buf_size, "%ju/%s", (uintmax_t) uid, name); |
Contributor
There was a problem hiding this comment.
Would be nice to handle truncation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--simulate=diff, a file whose mode, owner or group changed without its contents was listed in the report with nothing under it, because onlydiff -uon the contents was shown. The report now prints the permission, owner and group changes before the content diff, e.g.:Ticket: ENT-14694