Repository navigation
cf-serverd: Fixed classic CONTEXT reply including non-admitted classes - #6437
Open
Dhanu-dynamic wants to merge 1 commit into
Open
Dhanu-dynamic wants to merge 1 commit into
Dhanu-dynamic wants to merge 1 commit into
Conversation
ContextAccessControl() answers the classic CONTEXT/SCONTEXT request (sent by remoteclassesmatching()) by checking every persistent class that matches the client's regex against the access rules. The access flag was declared once for the whole loop and never reset, so after one class was admitted by a resource_type => "context" rule, every later matching class was returned as well, including classes that no rule admits. The TLS CONTEXT handler already checks each class on its own via acl_CheckRegex(). Changelog: Title Signed-off-by: Dhanraj E <dhanraj@labs.digiscrypt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContextAccessControl()incf-serverd/server_classic.canswers the classic CONTEXT/SCONTEXT request (sent byremoteclassesmatching()) by checking every persistent class that matches the client's regex against the access rules, butaccesswas declared once for the whole loop and never reset.resource_type => "context"rule, every later class matching the regex is returned too, including classes no rule admits. A host allowed viaallowlegacyconnectscan sendCONTEXT .*and read persistent classes it was never granted. The TLS CONTEXT handler already checks each class on its own viaacl_CheckRegex().accessis now scoped to each class. The new test intests/unit/protocol_test.cfails before the change (the unadmitted class is returned) and passes after.