Repository navigation
followup to Fix/textinput inputref - #650
Closed
flacoman91 wants to merge 2 commits into
Closed
flacoman91 wants to merge 2 commits into
flacoman91 wants to merge 2 commits into
Conversation
… cleanups add tests for rerender and unmount.
|
flacoman91
marked this pull request as ready for review
October 22, 2026 00:11
flacoman91
requested review from
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
October 22, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #649.
Thanks @soroush5 for your PR. I opened another PR to get our CI tests to run and also I had to add in some tests
Changes
inputRefor forwarded ref stays attached across rerendersnull, and set object refs back tonullon detachnullcallback pathHow to test this PR
yarn vitest run src/components/text-input/text-input.test.tsxinputRefcallback and confirm it is not called withnullon rerenderinputRefand confirm it runs on unmount