Skip to content

fix: harden provider recovery and session lifecycle - #42

Merged
darwin67 merged 17 commits into
mainfrom
rfd-5-phase-3-final-hardening
Sep 13, 2026
Merged

fix: harden provider recovery and session lifecycle#42
darwin67 merged 17 commits into
mainfrom
rfd-5-phase-3-final-hardening

Conversation

@darwin67

@darwin67 darwin67 commented Sep 12, 2026

Copy link
Copy Markdown
Member

Summary

  • order account, integration, recovery, and lifecycle locks to close deletion races
  • canonicalize supported model snapshot syntax and defer final-review credential admission
  • recover newly observed authorization attempts and stop terminal retries
  • preserve durable authorization outcomes and bound missing-session coordinator shutdown
  • expose accessible clipboard failures, keep device codes readable, and update the RFD checklist

Stack

Verification

  • DATABASE_PORT=5432 mix precommit — 640 passed, 5 live-provider tests excluded; Credo found no issues
  • rendered the active ChatGPT authorization state at 1280×900 / 2× DPR and exercised clipboard rejection

@github-actions github-actions Bot added the fix label Sep 12, 2026
@darwin67
darwin67 force-pushed the rfd-5-phase-3-final-hardening branch from 1144c8b to 42999fd Compare September 13, 2026 00:01
@darwin67
darwin67 force-pushed the rfd-5-phase-3-admission-hardening branch from 14b8640 to 151feb2 Compare September 13, 2026 00:01
This was referenced Sep 13, 2026
Merged
Merged
darwin67 added a commit that referenced this pull request Sep 13, 2026
@darwin67 Darwin Wu
feat(integrations): complete ChatGPT subscription support (#38)
6c8fa3d 
## Summary
- claim, poll, and complete ChatGPT device authorization through durable
generation-fenced transitions
- add ChatGPT subscription accounts and the device authorization UI
- lease and coordinate OAuth refresh, normalize rotated credentials, and
refresh just in time for inference
- validate subscription access and provide actionable reconnect guidance
- simplify authorization boundaries so this provider-integration layer
is independently lint-clean

## Stack
1. **This PR** — ChatGPT device authorization and OAuth refresh
2. #40 — immutable execution-route snapshots
3. #41 — invocation admission hardening
4. #42 — final concurrency and UX hardening

## Verification
- covered by the Phase 3 stack's passing `DATABASE_PORT=5432 mix
precommit` run

---------

Co-authored-by: Darwin Wu <tough.pasta0068@wunli88.com>
@darwin67
darwin67 force-pushed the rfd-5-phase-3-final-hardening branch from 42999fd to 8a7f269 Compare September 13, 2026 06:22
@darwin67
darwin67 force-pushed the rfd-5-phase-3-admission-hardening branch from 151feb2 to 424c551 Compare September 13, 2026 06:22
darwin67 added a commit that referenced this pull request Sep 13, 2026
@darwin67 Darwin Wu
feat(sessions): persist immutable execution routes (#40)
e6650e8 
## Summary
- snapshot the selected provider, model, integration, and credential
generation per turn
- persist capability contracts and enforce the durable route during
execution
- gate route changes through compatibility checks and queue approved
transitions
- reject unapproved route records and normalize replay across accepted
routes

## Stack
- Depends on #38
- Followed by #41 invocation admission hardening and #42 final
concurrency/UX hardening

## Verification
- covered by the Phase 3 stack's passing `DATABASE_PORT=5432 mix
precommit` run

---------

Co-authored-by: Darwin Wu <tough.pasta0068@wunli88.com>
@darwin67
darwin67 force-pushed the rfd-5-phase-3-final-hardening branch from 8a7f269 to 621bd71 Compare September 13, 2026 07:22
@darwin67
darwin67 force-pushed the rfd-5-phase-3-admission-hardening branch from 424c551 to 5b94664 Compare September 13, 2026 07:22
Base automatically changed from rfd-5-phase-3-admission-hardening to main September 13, 2026 07:44
Darwin Wu added 17 commits September 13, 2026 07:45
Darwin Wu
fix(integrations): order recovery transition locks
063911b
Darwin Wu
fix(agent): canonicalize model snapshot syntax
322b85b
Darwin Wu
fix(integrations): order audited lifecycle locks
87ce0ff
Darwin Wu
fix(agent): parse qualified model snapshots
4850bd8
Darwin Wu
fix(integrations): announce clipboard failures
58cb20c
Darwin Wu
fix(agent): canonicalize application model routes
1babfb9
Darwin Wu
fix(sessions): bound account deletion races
501164c
Darwin Wu
fix(integrations): recover observed authorization attempts
fe8f7fc
Darwin Wu
fix(sessions): finish deletion lifecycle handling
3facee5
Darwin Wu
fix(agent): defer final review admission
57b72e1
Darwin Wu
fix(integrations): trust durable authorization outcomes
2ed8365
Darwin Wu
refactor(agent): simplify review admission context
34ec711
Darwin Wu
refactor(integrations): simplify retry reconciliation
45b24d6
Darwin Wu
test(integrations): align deletion race outcomes
d6d7e47
Darwin Wu
test(sessions): avoid registry cleanup race
f8dda6e
Darwin Wu
fix(integrations): keep device codes readable
0cec04f
Darwin Wu
docs(rfd-5): record phase 3 hardening
846d43a
@darwin67
darwin67 force-pushed the rfd-5-phase-3-final-hardening branch from 621bd71 to 846d43a Compare September 13, 2026 07:45
@darwin67 darwin67 changed the title fix(rfd-5): close phase 3 hardening gaps fix: harden provider recovery and session lifecycle Sep 13, 2026
@darwin67
darwin67 merged commit 4277939 into main Sep 13, 2026
26 checks passed
@darwin67
darwin67 deleted the rfd-5-phase-3-final-hardening branch September 13, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@darwin67