Repository navigation
docs: tightening external sharing narrows pastes already shared - #76
Merged
Merged
Conversation
The design doc promised that tightening "Sharing outside the team" never changes pastes already shared. The code has always done the opposite, and #74 put the code's behaviour into the interface: - On save, Organizations.clamp_paste_audiences/1 rewrites existing audiences to fit the new setting. - On every read, shared access re-checks the workspace's current setting. That is the behaviour an owner needs when shutting off outside access after a leak, and because the clamp rewrites stored audiences, loosening the setting later does not quietly re-share anything. Update the doc to describe it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
Member
Author
|
Oracle review complete: signed off, no blockers. The design wording matches both current audience clamping on policy save and current-policy checks on shared reads. Loosening does not widen stored audiences or silently re-share pastes. This is documentation-only; no correction was needed. Review session: https://ampcode.com/threads/T-01a12594-e2f1-75be-b343-9239564f5c84 CI is green at the reviewed head. For PR78 this includes the fresh post-fix memory/local/S3 test matrix, Rust tests, formatting/linting, and production-container build; release/publication jobs skipped as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This settles the doc-vs-code mismatch flagged in #74.
docs/design.mdsaid that tightening "Sharing outside the team" never changes pastes already shared. The code does the opposite at two layers:Organizations.clamp_paste_audiences/1rewrites existing audiences to fit the new setting.The code's behaviour is the one to keep:
The doc now describes that behaviour. The UI has said the same since #74.
Doc-only change. No code changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
Generated by Claude Code