Repository navigation
refactor(adapter)!: unify business outputs in one JSON C carrier - #191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All eight business outputs now use the
json_outcarrier, with each business selected by its existing convertername. Callers receiveCompanyOperatorOutput { service_type, result_json, status_code }; converters assemble the complete business JSON response and the Demo displays that response directly.result_json_max_bytesfor capacity (default 8191 bytes, maximum 65536). Preserve per-business service mapping, independent output pools, batch row correspondence and atomic publication.Local validation: the canonical
./scripts/run_all_tests.shgate passes all 104 CTest entries. All eight business Demo paths were exercised using rules, mocks and an ONNX fixture. Nine optional GTests skip because real backends/models are disabled or unavailable; dedicated real-model E2E and target hardware were not exercised. Seven Whisper/Kite deployment configurations cannot fully validate in the default build because their backends are disabled.Breaking change for the unreleased project: previous output types and per-field capacity parameters are removed. For example,
keyword_out/keyword_matchbecomesjson_out/keyword_match, and result fields are read from the JSON payload.