Skip to content

refactor(cmake): split build setup and engine modules - #194

Merged
chamsechan merged 1 commit into
mainfrom
refactor/cmake-module-boundaries
Oct 12, 2026
Merged

chamsechan merged 1 commit into
mainfrom
refactor/cmake-module-boundaries

Conversation

@chamsechan

@chamsechan chamsechan commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

The root CMake file mixed compiler setup, dependency acquisition, runtime layer targets, and product assembly; ONNX Runtime and llama.cpp also shared one engine module. Split those responsibilities into ProjectSetup, Dependencies, RuntimeGraph, and ProductTargets, with separate modules for each open-source engine. Move the existing Kite integration into company/ and feed its compile definitions and libraries into the runtime graph through neutral variables.

Preserve the current CMake 3.19 entrypoints, engine pins, checksums, cache locations, and output layout. Company platform/toolchain setup and mirror rules remain outside this stage. Update CI cache keys and documentation, and add a CMake-only structural check for the thin root, company module boundary, dependency aggregation, and include resolution.

Validation:

  • Canonical repository gate: 390 passed, 1 optional GGUF test skipped because EDGEFLOW_TEST_LLAMA_GGUF was not supplied.
  • Minimal configuration generated successfully; ONNX Runtime + llama.cpp + Whisper SDK compiled and linked successfully.
  • Cache publication/import/fallback tests and structural negative checks passed.
  • Kite conflict checks passed without loading a package; the real Kite SDK and company target hardware were not exercised.

@chamsechan
chamsechan merged commit 84b8cb7 into main Oct 12, 2026
6 checks passed
@chamsechan
chamsechan deleted the refactor/cmake-module-boundaries branch October 12, 2026 06:36
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T06:38:14.140024Z a9e59c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant