perf: old dequeue is scheme faster for ucx-arm - #3928
Merged
Conversation
The dequeue optimization in #3916 creates a performance regression (loss of 1ns/day) for NAMD on Vista at large scale. This adds CMK_NODE_QUEUE_LOCK_BEFORE_CHECK to switch back to the prior scheme and enables it in the ucx-linux-arm8 conv-mach.h
ericjbohm
added
smp
ritvikrao
approved these changes
Jul 7, 2026
Contributor
|
1ns/day out of what? (as in what is the percent increase in time). |
Contributor
Author
|
STMV_8M runs at better than 13ns/day with this enabled, vs about
11.5ns/day. So it is around 10%.
…On Tue, Jul 7, 2026 at 10:17 AM Laxmikant Kale ***@***.***> wrote:
*lvkale* left a comment (charmplusplus/charm#3928)
<#3928 (comment)>
1ns/day out of what? (as in what is the percent increase in time).
—
Reply to this email directly, view it on GitHub
<#3928?email_source=notifications&email_token=AB3HFH62BO3GT5N7I753QAL5DUH7DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJQGUZTONBYGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4905374854>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3HFH2W3SWY23J54Z5D7PD5DUH7DAVCNFSNUABFKJSXA33TNF2G64TZHMYTQMRYGYYDSNJWHNEXG43VMU5TIOBSGM2DAOBSGM42C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AB3HFHZMOGKNZKEIISOWXUL5DUH7DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJQGUZTONBYGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AB3HFH6U6DNUNQEJJ3GRT735DUH7DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJQGUZTONBYGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dequeue optimization in #3916 creates a
performance regression (loss of 1ns/day) for NAMD on Vista at large scale. This adds CMK_NODE_QUEUE_LOCK_BEFORE_CHECK to switch back to the prior scheme and enables it in the
ucx-linux-arm8 conv-mach.h