avoid PHP 8.5 deprecation in applyComplement - #4
Open
guillaume-ernst wants to merge 1 commit into
Open
guillaume-ernst wants to merge 1 commit into
guillaume-ernst wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the PHP 8.5 deprecation triggered when
applyComplement()passes a negative integer tochr().The complemented value is now masked with
0xFF, preserving the expected 8-bit complement while ensuring thatchr()receives a value between 0 and 255.A regression test was added to convert PHP 8.5 deprecations into exceptions, demonstrating the issue and preventing it from being reintroduced.
Verified with PHP 8.5.11: 140 tests and 154 assertions pass without deprecations from
applyComplement().