Repository navigation
fix(ui): focus newly opened terminal sessions - #56
Open
ChrisLauinger77 wants to merge 1 commit into
Open
ChrisLauinger77 wants to merge 1 commit into
ChrisLauinger77 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Clicking the terminal button for the first time opened the panel without keyboard focus, so typing required another click inside the terminal. Focus was only applied when reattaching an existing session. Apply it after both setup paths so newly opened and reopened terminals accept typing immediately. Extend the terminal flow test to check focus, echoed keystrokes, and retained input after reopening.
Development StrictMode masked the missing call by running the attachment effect twice. The production preview reproduced the failure before the fix and passes afterward.
Screenshots
This changes keyboard focus without changing the visual layout. The browser regression verifies focus and typed input after opening and reopening.
Validation
Checklist
pnpm typecheck && pnpm testpassCLAUDE.mddocuments the focus behavior and StrictMode testing pitfallRust, engine integration, undo, and color checks are not applicable to this focus-only frontend change.