Skip to content

feat(issuing): document scheduled_revocation_date, last_activated_on and update-card status - #463

Open
armando-rodriguez-cko wants to merge 2 commits into
masterfrom
feat/INT-1700-issuing-card-scheduled-revocation
Open

armando-rodriguez-cko wants to merge 2 commits into
masterfrom
feat/INT-1700-issuing-card-scheduled-revocation

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
Documents card scheduled_revocation_date/status/last_activated_on per the 2026-09-17 swagger delta (INT-1700), and reflects encrypted_cvv's removal from update-card-response (added by INT-1695, removed by this same delta). This SDK models issuing card requests/responses as generic Object with no per-field typed classes, so the change is JSDoc + test coverage, not new types.

Changes

  • src/api/issuing/cards.js — JSDoc for createCard/updateCard/getCardDetails/activateCard updated with the new fields and the encrypted_cvv removal
  • test/issuing/cards/cards-unit.js — mocked coverage for every new/removed field
  • test/issuing/cards/cards-it.js — removed an integration test that asserted encrypted_cvv is still returned (no longer true against the live API)

API Reference

  • POST /issuing/cards
  • PATCH /issuing/cards/{cardId}
  • POST /issuing/cards/{cardId}/activate
  • GET /issuing/cards/{cardId}

Breaking changes
update-card-response no longer includes encrypted_cvv (API-forced, minor per SDK, same precedent as INT-1695's activation_date rename).

README
No README changes needed.

🤖 Generated with Claude Code

…and update-card status

Swagger 2026-09-17: add-card-request and update-card-request gain
scheduled_revocation_date (replaces deprecated revocation_date); update-card-request
gains status to reactivate an inactive/suspended card; activate-card-response,
add-card-response and get-card-response gain last_activated_on; update-card-response
drops encrypted_cvv (last_modified_date and _links stay). This SDK models request/
response bodies as generic Object, so this is a JSDoc + test update, no new types.
@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team September 24, 2026 16:09
@agent-wall-e

agent-wall-e Bot commented Sep 24, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change is purely JSDoc documentation updates and test coverage adjustments for existing API fields, with no new code paths, endpoints, data persistence, auth changes, or external integrations introduced.

Operational gates

  • ✅ jira_ticket (INT-1700)
  • ✅ independent_review

Files analysed: 3


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 24, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change is purely JSDoc documentation updates and test coverage adjustments for existing API fields, with no new code paths, endpoints, data persistence, auth changes, or external integrations introduced. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change is purely JSDoc documentation updates and test coverage adjustments for existing endpoints, with no new code paths, types, persisted data, auth changes, or external integrations introduced.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

david-ruiz-cko
david-ruiz-cko previously approved these changes Sep 25, 2026
…ual cards

Swagger 2026-09-23 split update-card-response into a virtual/physical
discriminator; the virtual variant adds is_single_use (specifies whether the
card is set to expire after a single use). Physical cards never send it. This
SDK models responses as generic Object, so this is a JSDoc + test update.
@agent-wall-e

agent-wall-e Bot commented Sep 25, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change is purely JSDoc documentation updates and test coverage adjustments for existing API fields, with no new code paths, endpoints, types, auth changes, or persisted data.

Operational gates

  • ✅ jira_ticket (INT-1700)
  • ✅ independent_review

Files analysed: 3


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 25, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change is purely JSDoc documentation updates and test coverage adjustments for existing API fields, with no new code paths, endpoints, types, auth changes, or persisted data. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change is purely JSDoc documentation updates and test coverage adjustments for existing endpoints and object fields, with no new code paths, types, external integrations, auth changes, or persisted data.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants