feat(payments): add PaymentSetup accommodation/airline fields - #239
Merged
armando-rodriguez-cko merged 1 commit intoSep 17, 2026
Merged
armando-rodriguez-cko merged 1 commit into
armando-rodriguez-cko merged 1 commit into
Conversation
Adds total_number_of_guests, refundable, delivery_recipient and host
to PaymentSetupAccommodation, and total_number_of_passengers,
travel_type, trip_type, refundable, delivery_recipient, ancillaries
and insurance to PaymentSetupAirline (POST/GET/PUT /payments/setups,
POST /payments/setups/{id}/confirm/{payment_method_name}).
Also fixes Industry, which used the wrong field names
(airline_data/accommodation_data instead of airline/accommodation)
and reused an unrelated Payments-contexts type for airline, so the
data never reached the API correctly.
🟡 Risk Classification: MINORApproval route: AI Review + Human Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
david-ruiz-cko
approved these changes
Sep 17, 2026
armando-rodriguez-cko
deleted the
feat/INT-1696-payment-setup-accommodation-airline-fields
branch
September 17, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the new PaymentSetupAccommodation and PaymentSetupAirline fields from the 2026-09-08 spec update to
POST/GET/PUT /payments/setupsandPOST /payments/setups/{id}/confirm/{payment_method_name}. Also fixesIndustry, which used the wrong field names and reused an unrelated Payments-contexts type for airline, so the data never reached the API correctly.Changes
checkout_sdk/payments/setups/setups.py— addedPaymentSetupAccommodation/PaymentSetupAirline(previouslyIndustryused non-spec field namesairline_data/accommodation_datainstead ofairline/accommodation, andAirlineData.ticketincorrectly reused a Payments-contexts type); addedtotal_number_of_guests,refundable,delivery_recipient,hostto accommodation andtotal_number_of_passengers,travel_type,trip_type,refundable,delivery_recipient,ancillaries,insuranceto airlinetests/payments/setups/payment_setups_serialization_test.py— added roundtrip coverage for both schemas including every new fieldAPI Reference
POST /payments/setupsPUT /payments/setups/{id}GET /payments/setups/{id}POST /payments/setups/{id}/confirm/{payment_method_name}Breaking changes
None for the new fields (additive). The
Industryfield-name fix changes wire format, but the old shape never matched the API contract, so nothing that worked before is affected.README
No README changes needed.