Skip to content

feat(issuing): add scheduled_revocation_date and status to update-card - #211

Open
armando-rodriguez-cko wants to merge 2 commits into
masterfrom
feat/INT-1700-issuing-card-scheduled-revocation
Open

armando-rodriguez-cko wants to merge 2 commits into
masterfrom
feat/INT-1700-issuing-card-scheduled-revocation

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
Adds scheduled_revocation_date and status to UpdateCardRequest per the 2026-09-17 swagger delta (INT-1700). update-card-response no longer includes encrypted_cvv on the live API (added by INT-1695, removed by this same delta); this SDK has no typed issuing response classes, so no response-side code change is needed.

Changes

  • lib/checkout_sdk/issuing/update_card_request.rb — gains scheduled_revocation_date and status, revocation_date documented as deprecated in YARD

API Reference

  • PATCH /issuing/cards/{cardId}

Breaking changes
None on this SDK's side (no typed response class carried encrypted_cvv to begin with).

README
No README changes needed.

🤖 Generated with Claude Code

Swagger 2026-09-17: update-card-request gains scheduled_revocation_date (replaces
deprecated revocation_date) and status to reactivate an inactive/suspended card.
update-card-response no longer includes encrypted_cvv on the live API; this SDK
has no typed issuing response classes, so no response-side code change is needed.
@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team September 24, 2026 16:12
@agent-wall-e

agent-wall-e Bot commented Sep 24, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds two new optional fields to an existing request class by extending its attr_accessor list, reusing the existing endpoint and abstraction without touching auth, persistence, external integrations, or any other sensitive concerns.

Operational gates

  • ✅ jira_ticket (INT-1700)
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 24, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change only adds two new optional fields to an existing request class by extending its attr_accessor list, reusing the existing endpoint and abstraction without touching auth, persistence, external integrations, or any other sensitive concerns. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds two new optional attributes to an existing request data class, reusing the existing endpoint and abstraction without touching auth, persistence, external integrations, or any other sensitive area.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

david-ruiz-cko
david-ruiz-cko previously approved these changes Sep 25, 2026
…ual cards

Swagger 2026-09-23 split update-card-response into a virtual/physical
discriminator; the virtual variant adds is_single_use (specifies whether the
card is set to expire after a single use). Physical cards never send it. This
SDK has no typed issuing response classes, so this is a doc + test update.
@agent-wall-e

agent-wall-e Bot commented Sep 25, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds two new optional attributes to an existing request class and updates YARD documentation/comments, with no new endpoints, auth changes, persisted data, external integrations, or background processes introduced.

Operational gates

  • ✅ jira_ticket (INT-1700)
  • ✅ independent_review

Files analysed: 3


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 25, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change only adds two new optional attributes to an existing request class and updates YARD documentation/comments, with no new endpoints, auth changes, persisted data, external integrations, or background processes introduced. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds new optional attributes to an existing request class and updates YARD documentation/comments, with no new endpoints, persisted data, auth changes, or external integrations introduced.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants