Skip to content

docs: correct the bulk-edit failure comment - #231

Merged
chhoumann merged 1 commit into
masterfrom
fix/bulk-warning-comment
Oct 24, 2026
Merged

chhoumann merged 1 commit into
masterfrom
fix/bulk-warning-comment

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

The comment above the bulk-edit failure logging in src/bulk/bulkMetadataEditor.ts said LogManager.logWarning routes to logError. That stopped being true in #228, which sends warnings to each logger's logWarning. The comment now says why the failed notes go to the console: the summary Notice already reports the count and says "see console for failed notes".

Comment-only change, no behavior change.

Verification

  • pnpm run lint, pnpm run build, pnpm run test (365 passed).

Release impact: none.


Note

Low Risk
Comment-only change with no code or behavior impact.

Overview
Updates the comment above bulk-edit failure logging in bulkMetadataEditor.ts so it matches current behavior: failed notes are logged once via console.warn instead of per-note Notices, because the summary Notice already reports the failure count and tells users to check the console.

Removes the outdated claim that LogManager.logWarning routes to logError (that changed in #228). No runtime or logging behavior changes—documentation only.

Reviewed by Cursor Bugbot for commit 20d565b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Correct failure-reporting comments in BulkMetadataEditor batch update

Fixes outdated comments in bulkMetadataEditor.ts. The comments now match the code: failures are logged once to the console, and the summary Notice shows the failure count and points users to the console. No code behavior changes.

Macroscope summarized 20d565b.

@chhoumann
chhoumann merged commit 5de91e4 into master Oct 24, 2026
11 of 14 checks passed
@chhoumann
chhoumann deleted the fix/bulk-warning-comment branch October 24, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant