Repository navigation
docs: correct the bulk-edit failure comment - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment above the bulk-edit failure logging in
src/bulk/bulkMetadataEditor.tssaidLogManager.logWarningroutes tologError. That stopped being true in #228, which sends warnings to each logger'slogWarning. The comment now says why the failed notes go to the console: the summary Notice already reports the count and says "see console for failed notes".Comment-only change, no behavior change.
Verification
pnpm run lint,pnpm run build,pnpm run test(365 passed).Release impact: none.
Note
Low Risk
Comment-only change with no code or behavior impact.
Overview
Updates the comment above bulk-edit failure logging in
bulkMetadataEditor.tsso it matches current behavior: failed notes are logged once viaconsole.warninstead of per-note Notices, because the summary Notice already reports the failure count and tells users to check the console.Removes the outdated claim that
LogManager.logWarningroutes tologError(that changed in #228). No runtime or logging behavior changes—documentation only.Reviewed by Cursor Bugbot for commit 20d565b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Correct failure-reporting comments in
BulkMetadataEditorbatch updateFixes outdated comments in bulkMetadataEditor.ts. The comments now match the code: failures are logged once to the console, and the summary Notice shows the failure count and points users to the console. No code behavior changes.
Macroscope summarized 20d565b.