Repository navigation
build(deps-dev): bump obsidian-e2e to 0.14.0 - #517
Merged
Merged
Conversation
obsidian-e2e 0.14.0 drops its vite-plus peer, so vite-plus 0.1.24 and the 50 lock entries only it pulled in leave the dev tree. The scoped oxfmt override existed only for vite-plus and goes with it.
Deploying podnotes with
|
| Latest commit: |
92a354e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c14011c.podnotes.pages.dev |
| Branch Preview URL: | https://build-obsidian-e2e-0-14.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot alerts 214 to 218 on this repository (one high, three medium, one low) are all in vite-plus 0.1.24. It is a dev-only package that reached the tree through obsidian-e2e 0.13.0's required peer
vite-plus: ^0.1.11. That peer range is also why Dependabot's security update to vite-plus 1.1.0 failed on 2026-10-23.obsidian-e2e 0.14.0 drops the vite-plus peer. This PR bumps obsidian-e2e to
^0.14.0, which takes vite-plus out of the dev tree and resolves all five alerts. It also removes thevite-plus>oxfmtoverride. PR 402 added that override only to patch vite-plus's nested formatter and said to drop it once obsidian-e2e moved off vite-plus 0.1.x.Nothing ships differently.
main.jsis byte-identical to master's.Lockfile
obsidian-e2emoves from 0.13.0 to 0.14.0. Itsyamlrange moves from^2.8.2to^2.8.3, which the existingyaml2.9.1 already satisfies.vite-plus0.1.24 and everything only it pulled in: its nested oxlint 1.67.0, oxlint-tsgolint 0.23.0 and their platform bindings, the@voidzero-dev/vite-plus-*packages, and the hoisted copies they alone used (@oxc-project/runtime,@oxc-project/types0.133.0,@oxlint/plugins,@standard-schema/spec,es-module-lexer1.7.0,tinybench2.9.0,pixelmatch,pngjs,sirv,@polka/url,mrmime,totalist). Every removed entry was markedpeer. Vitest and rolldown keep their own nested newer copies ofes-module-lexer,tinybenchand@oxc-project/types.libcfields that newer npm writes, so the lockfile was rebuilt from master's with only these changes, and all 38libcfields stay.Simply removing the override and running
npm installdoes not work. npm keeps vite-plus because oxfmt and oxlint list it as an optional peer, and without the override it brings back vite-plus's own oxfmt 0.52.0 and tinypool. The lockfile entries for vite-plus had to go so that npm would prune it.Verification
Node v22.23.4, npm 10.9.9.
npm ciinstalls 492 packages, down from 515.npm ls --allexits 0, andnpm ls vite-plus --allis empty. oxfmt 0.73.0 and oxlint 1.88.0 resolve and run.npm auditno longer lists vite-plus. The remaining fast-uri and undici (via wrangler) advisories are on master too.npm run lint,npm run format:check,npm run typecheck,npm run buildandnpm run docs:buildpass.npm run testpasses. svelte-check checks 22 files with 0 errors and 0 warnings, and Vitest passes 126 files and 2,782 tests.npm run test:toolingpasses 6 files and 41 tests.npm run sizereports 314,268 raw bytes and 101,575 gzip bytes, the same as master.cmpagainst master's build is equal, and SHA-256 is04ea3cf14d5dab0da54f7a48d4340b3b045b31402c0ec734c200cbfb13dad5df.podnotes-build-obsidian-e2e-0-14, in isolated Obsidian 1.14.4 on headless Linux:npm run test:e2e -- tests/e2e/settings-tab.test.ts tests/e2e/journey-player.test.tspasses 2 files and 22 tests.npm run obsidian:e2e -- eval code='Boolean(app.plugins.plugins.podnotes)'returnstrue, anddev:errorsreports no errors.obsidian-e2e/capturepath works.npm run screenshot:e2e-obsidian,capture:e2e-obsidian -- screenshot,record:e2e-obsidianandcapture:e2e-obsidian -- sheetall produce the expected PodNotes view.npm run stop:e2e-obsidianstops the instance, and--dry-runreportspids: none.The 0.14.0 runner and capture code is unchanged apart from bundler output, such as constant folding and
@__PURE__annotations. PodNotes uses neitherobsidian-e2e/matchersnorvite-plus/test, so the 0.14.0 matcher change does not apply here.Release impact
None. This is a dev dependency only. No settings, storage, public API or URI changes.
Note
Low Risk
Dev-only dependency and lockfile cleanup with no runtime or
main.jschanges; main risk is e2e tooling behavior on the new obsidian-e2e release.Overview
Bumps the dev dependency obsidian-e2e from
^0.13.0to^0.14.0and refreshes package-lock.json so vite-plus and its large transitive dev tree are pruned from the install.obsidian-e2e 0.14.0 no longer requires vite-plus as a peer, which clears the path for resolving Dependabot alerts tied to vite-plus 0.1.24. The
package.jsonoverrides entry that forced vite-plus’s nested oxfmt to match the repo’s formatter is removed because that workaround only existed while obsidian-e2e pulled in vite-plus.There are no application or shipped artifact changes—only dependency and lockfile updates. E2E still goes through
scripts/obsidian-e2e.mjsand the obsidian-e2e runner APIs unchanged in this repo.Reviewed by Cursor Bugbot for commit 92a354e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Bump
obsidian-e2edev dependency from ^0.13.0 to ^0.14.0Updates the dev dependency range in package.json and regenerates package-lock.json. Also removes the vite-plus oxfmt formatter mapping. Behavioral Change: installs now resolve
obsidian-e2e0.14.x instead of 0.13.x.Macroscope summarized 92a354e.