Repository navigation
docs: chapters also come from an episode's MP3 file - #523
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
6e56684
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09befe9f.podnotes.pages.dev |
| Branch Preview URL: | https://docs-id3-chapters.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.23.0 shipped ID3 chapters (#521, #512). The docs said chapters come only from the feed's chapters file. This updates the Chapters panel in
player.mdand{{chapters}}intemplates.md: a feed chapters file still wins, else PodNotes reads the chapters embedded in a streamed MP3, asking for only the start of the file, and after a restart only once you select Play. Vault files get no chapters this way.Verification
npm run docs:buildpasses (22 pages, all 112 legacy fragments resolve).src/utility/fetchChapters.ts,src/utility/id3Chapters.ts, andsrc/createPodcastNote.tsat 2.23.0, and in Obsidian 1.14.4 on Linux: Efervesciencia episode 756 (https://www.spreaker.com/show/2892576/episodes/feed) showed its 4 MP3 chapters in the Chapters panel and in{{chapters}}.Release impact
None. Docs only.
Note
Low Risk
Documentation-only updates with no code or runtime behavior changes.
Overview
Documents MP3-embedded chapters alongside the existing feed chapters file, matching behavior shipped in 2.23.0.
In
player.md, the Chapters panel is described as appearing when the episode has chapters (not only when the feed supplies a chapters file). A new subsection explains precedence: feed chapters file first, otherwise ID3 chapters from a streamed MP3 (partial fetch at file start), deferred until Play after restart, and no chapters for vault-local playback.In
templates.md,{{chapters}}is updated the same way: feed<podcast:chapters>first, then embedded MP3 chapters for streamed feed episodes; empty output on failed requests or when no chapters exist (replacing wording that only mentioned an empty chapters file).Reviewed by Cursor Bugbot for commit 6e56684. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Document that chapters also come from an episode's MP3 file
chapterstemplate. An episode without chapters, or a failed request, produces an empty valueMacroscope summarized 6e56684.