Repository navigation
ci: move the release toolkit to v5.0.0 and the App client ID - #2256
Conversation
Pin every obsidian-plugin-workflows reusable workflow to v5.0.0. v5 replaces the prepare workflow's app-id input with client-id, so the prepare stub now passes vars.RELEASE_APP_CLIENT_ID. A dryRun dispatch now also mints a read-only App token to check the credentials.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update reusable workflow references .github/workflows/release-prepare.yml, .github/workflows/release-trigger.yml, .github/workflows/release.yml |
All three workflows now reference v5.0.0. The Prepare workflow passes vars.RELEASE_APP_CLIENT_ID through client-id and updates its dry-run comment to mention the App credential check. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- chhoumann/quickadd#2254: Pins the same three reusable release workflows to v4.1.0, which this PR updates to v5.0.0.
- chhoumann/quickadd#2255: Adds the dry-run input that this PR retains while updating the shared workflow version and dry-run comment.
- chhoumann/quickadd#2253: Changes release automation setup related to reusable workflow dependency resolution; this PR updates the same workflows.
Merge Risk: 
e9a92
-
No actionable merge-blocking risk is established by the reviewed changes.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title "ci: move the release toolkit to v5.0.0 and the App client ID" matches the main change. The three workflow files pin the reusable workflows to v5.0.0 instead of v4.1.0. The prepare workflow … Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "ci: move the release toolkit to v5.0.0 and the App client ID" matches the main change. The three workflow files pin the reusable workflows to v5.0.0 instead of v4.1.0. The prepare workflow also switches its App input from app-id to client-id. The title names both the version bump and the client ID switch, so it covers the primary change. It is specific and does not use vague terms. Length is 60 characters and 12 words, which is acceptable for a title.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the release trail,
With carrots packed and ears set sail.
Three workflows hop to version five,
The client ID helps them arrive.
Dry-run notes the checks in view,
Then off the release bunnies flew.
Comment @coderabbitai help to get the list of available commands.
Summary
chhoumann/obsidian-plugin-workflowsreusable workflow to v5.0.0 (d6b3b8c2cf460059238043b32a08dcaa3be4828f).app-idinput withclient-id, becauseactions/create-github-app-tokendeprecatesapp-id. The prepare stub now passesclient-id: ${{ vars.RELEASE_APP_CLIENT_ID }}. TheRELEASE_APP_CLIENT_IDrepository variable is set to the App's Client ID.dryRundispatch of Prepare release now also mints a read-only App token and checks its slug. It still opens no release PR.Test plan
dryRun=true: https://github.com/chhoumann/quickadd/actions/runs/40102097129. Check release-bot App minted a token for the expected slug, Open release PR was skipped, and open PRs, release branches and the latest release were unchanged.Note
Medium Risk
Changes release automation and GitHub App authentication inputs; misconfigured
RELEASE_APP_CLIENT_IDcould break prepare/dry-run until fixed.Overview
Upgrades all three release pipeline caller workflows (
release-prepare,release-trigger,release) to obsidian-plugin-workflows v5.0.0 by pinning the reusable workflow refs tod6b3b8c2cf460059238043b32a08dcaa3be4828f.Prepare release now passes
client-idfromvars.RELEASE_APP_CLIENT_IDinstead ofapp-idfromvars.RELEASE_APP_ID, matching v5 andactions/create-github-app-token’s move away fromapp-id. Comments note thatdryRundispatch also validates App credentials (token mint + slug check) without opening a release PR.Reviewed by Cursor Bugbot for commit e9a92b2. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Move release toolkit workflows to v5.0.0 and rename App ID input to
client-idapp-idinput withclient-idin the release-prepare job, now sourced from theRELEASE_APP_CLIENT_IDsecret instead ofRELEASE_APP_ID.RELEASE_APP_CLIENT_IDsecret exists in the repo, sinceRELEASE_APP_IDis no longer used.Macroscope summarized e9a92b2.
Summary by CodeRabbit