A README that shows the application and pictures - #2
Merged
Conversation
The README described phase 5 and claimed door swing, clearance and multi-floor were not built. All three have been for four phases. Rewritten against PLAN.md §12 rather than patched, including the part §12 does well: what is deferred, what is approximate, what is unmeasured, and what is synthetic. A README that only lists what works is the same silent lie as a stale screenshot. Six captures, generated by driving the real app rather than taken by hand (`pnpm media`, a separate Playwright config so a GIF encode can never gate CI). They reuse e2e/coords.ts, so geometry is placed before anything zooms or fits — Fit invalidates that mapping — and each capture asserts the state it is photographing: the walk clip fails if the walker does not reach the bedroom, the clearance shot fails if the issue is not listed. Two things the walkthrough clip needed. Aiming cannot use the turn keys: the walk loop caps a step at MAX_STEP_SECONDS, so holding a key through 150ms PNG encodes turns about 60 degrees where the clock says 90, and the walker misses the door. Mouse-look is applied per pointer event, so a 409px drag is exactly 90 degrees whatever the machine is doing. And the clip plays back at the rate its frames were actually taken, or a walk reads as a run. tsconfig now includes media/, so the capture script is typechecked like everything else. CI is untouched and never runs it. Claude-Session: https://claude.ai/code/session_01KFW9vbazRJhHnsDXiXP8ij
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README described phase 5 and claimed door swing, clearance and multi-floor were not built. All three have been for four phases. Rewritten against PLAN.md §12 rather than patched, including the part §12 does well: what is deferred, what is approximate, what is unmeasured, and what is synthetic. A README that only lists what works is the same silent lie as a stale screenshot.
Six captures, generated by driving the real app rather than taken by hand (
pnpm media, a separate Playwright config so a GIF encode can never gate CI). They reuse e2e/coords.ts, so geometry is placed before anything zooms or fits — Fit invalidates that mapping — and each capture asserts the state it is photographing: the walk clip fails if the walker does not reach the bedroom, the clearance shot fails if the issue is not listed.Two things the walkthrough clip needed. Aiming cannot use the turn keys: the walk loop caps a step at MAX_STEP_SECONDS, so holding a key through 150ms PNG encodes turns about 60 degrees where the clock says 90, and the walker misses the door. Mouse-look is applied per pointer event, so a 409px drag is exactly 90 degrees whatever the machine is doing. And the clip plays back at the rate its frames were actually taken, or a walk reads as a run.
tsconfig now includes media/, so the capture script is typechecked like everything else. CI is untouched and never runs it.