feat(source-control): edge-anchored sidebar toggle, branches header cleanup, orange current-branch accents - #349
feat(source-control): edge-anchored sidebar toggle, branches header cleanup, orange current-branch accents#349chriswritescode-dev wants to merge 1 commit into
Conversation
…leanup, orange current-branch accents
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe PR redesigns the sidebar collapse handle and its accessibility behavior. It also simplifies branch controls, removes ahead/behind status display, and changes current-branch indicators to orange. ChangesSidebar controls
Branch interface
Priority: ⬇️ Low — Defer this source-control UI refresh because it is limited to sidebar controls, branch-tab layout, colors, and accessibility tests. Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This updates sidebar and branch UI presentation while preserving collapse behavior, branch status refresh, and search availability. The change is ready to merge with no identified production risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the problem, fix, testing, and manual validation steps, but it does not use the required template sections. It omits the Type of Change and Checklist sections and does not provide their checkbox selections. Resolution Add the required ## Summary, ## Type of Change, and ## Checklist sections. Select the applicable change type and confirm the style, TypeScript, test coverage, lint, and typecheck items. Keep the existing problem, fix, testing, and manual test details as supporting content.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Problem
The source-control panel had a bulky sidebar toggle in the desktop sidebar header and a cluttered branches tab: a redundant "Current: " header, a detached search input, and full-width buttons. Current-branch accents also reused the same emerald used for ahead/stage states, so the checked-out branch didn't stand out.
Fix
Sidebarrenders its own toggle (only whenonToggleis passed) as an absolute vertical pill on the right edge, with an orange accent bar, hover chevron, andaria-expanded; removed the toggle row fromDesktopSidebarh-10bg-orange-500/10andGIT_UI_COLORS.currentchanged from emerald to orange, distinguishing "current" from ahead/stage statesaria-expandedbehaviorTesting
vitest src/components/ui/sidebar.test.tsx: 11 passedpnpm lint:frontendcleantsc -b --noEmitcleanHow to test manually
Open the source-control panel: hover the sidebar's right edge for the collapse pill, check the Branches tab header (search + compact Branch/Worktree buttons), and note the orange accent on the current branch row and panel header.
Summary by CodeRabbit