Import PKCS8 EC PEM keys whose public point looks like ASN.1 - #443
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
An uncompressed point can decode as an OCTET STRING when the first coordinate byte is a plausible length. Keep that BIT STRING raw and do not read past a short buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442
Some PKCS8 EC private keys throw RangeError in JWK.asKey when the public point happens to parse as nested ASN.1. An uncompressed point starts with 0x04 then X and Y. When the first byte of X is a plausible length, the forge ASN.1 decoder treats that BIT STRING as an OCTET STRING and the importer then calls readUInt16BE on a one byte buffer.
The importer now keeps that BIT STRING as raw bytes, reads the uncompressed prefix without assuming two bytes are present, and fills X and Y from the private scalar when the point is missing.
I ran the mocha suite. 496 tests passed.