Bump tools pin to v0.8.40 in all release workflows - #1224
Closed
ibrahim halatci (ihalatci) wants to merge 2 commits into
Closed
Bump tools pin to v0.8.40 in all release workflows#1224ibrahim halatci (ihalatci) wants to merge 2 commits into
ibrahim halatci (ihalatci) wants to merge 2 commits into
Conversation
build-package.yml and update_package_properties.yml still cloned tools
v0.8.36, while build-citus-community-nightlies.yml was already on
v0.8.39. Align all three.
v0.8.36 has a bug in citus_package.py get_postgres_versions(): the
nightly exclusion filter iterated release_versions instead of
nightly_versions, so nightly versions were rebuilt from the
already-release-filtered list. This became reachable once pg_exclude.yml
gained a non-empty nightly block (nightly: all: [19]) - previously
nightly: {} was falsy and the block never ran.
Between v0.8.36 and v0.8.39 the scripts these two workflows invoke
change only additively:
- citus_package.py: adds ubuntu,resolute mapping; fixes the nightly
filter; includes build stdout+stderr in the failure exception
- upload_to_package_cloud.py: adds ubuntu/resolute distro id
- common_tool_methods.py: adds resolute to the ubuntu release list
update_package_properties.py itself is unchanged between the two tags.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
Retarget from v0.8.39 to v0.8.40, and include build-citus-community-nightlies.yml so all three workflows share a single pin rather than leaving it behind at v0.8.39. v0.8.40 adds three commits on top of v0.8.39: 5c2b3e5e Handle known ARM64 libc6 diversion warnings (#433) 7226f926 Retire Debian Bullseye from packaging tools (#432) f1258e6a Do not delete the caller's directory in pipeline mode (#425) MERGE ORDER MATTERS: #432 removes "bullseye" from supported_platforms in common_tool_methods.py, from platform_names in citus_package.py and from the package cloud distro map in upload_to_package_cloud.py. decode_os_and_release() validates os_release against supported_platforms and raises ValueError for an unknown release, so any workflow still passing --platform debian/bullseye fails immediately under v0.8.40. build-package.yml and build-citus-community-nightlies.yml both still list debian/bullseye in their platform matrices. PR #1233 removes it from both. #1233 must merge before this change, otherwise the debian/bullseye legs break. update_package_properties.yml is not platform-scoped and is unaffected either way. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
ibrahim halatci (ihalatci)
changed the title
ibrahim halatci (ihalatci)
pushed a commit
that referenced
this pull request
Sep 10, 2026
Fold the net changes from #1224 (head b16a79c) into #1233 without replaying the intermediate v0.8.39 bump. Preserve the Bullseye matrix retirement and ARM64 debsigner build-context fix, removing the merge-order dependency between these two PRs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
folded into #1233 |
ibrahim halatci (ihalatci)
pushed a commit
that referenced
this pull request
Sep 10, 2026
* Retire Bullseye from Citus release and nightly builds Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix arm64 Citus release debsigner build context Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 555499a) * Align release workflow tools pins to v0.8.40 Fold the net changes from #1224 (head b16a79c) into #1233 without replaying the intermediate v0.8.39 bump. Preserve the Bullseye matrix retirement and ARM64 debsigner build-context fix, removing the merge-order dependency between these two PRs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets the
citusdata/toolsclone pin tov0.8.40(5c2b3e5e) in all three workflows that consume it, so they share one pin instead of drifting.build-package.yml(L64)v0.8.36v0.8.40update_package_properties.yml(L53)v0.8.36v0.8.40build-citus-community-nightlies.yml(L55)v0.8.39v0.8.40+3/−3, pin strings only.Why
The original driver was a bug in
citus_package.py::get_postgres_versions(), fixed inv0.8.39. Its nightly exclusion filter iterated the wrong list:This was dormant while
pg_exclude.ymlhadnightly: {}(falsy). It became reachable the momentall-citusgained a non-emptynightly: all: [19]for the PG19 work, at which point nightly builds would silently resolve the wrong PG set rather than fail loudly.Since then
v0.8.40shipped, so this pins to that instead.What
v0.8.40adds overv0.8.39libc6protective-diversion warnings inpackaging_warning_handler.pycitusdata/tools#432 removes
bullseyefromsupported_platformsincommon_tool_methods.py, fromplatform_namesincitus_package.py, and from the package-cloud distro map inupload_to_package_cloud.py.citus_package.pybuilds its--platformargparsechoicesfrom those maps, sodebian/bullseyeis no longer an accepted value and the job dies during argument parsing, before any build work.This is now confirmed on this PR, not just predicted — all three
debian/bullseyelegs fail within seconds:build-package.ymlandbuild-citus-community-nightlies.ymlboth still listdebian/bullseyein their platform matrices. #1233 removes it from both.debian/bullseyelegs break as above.There is no textual conflict between the two PRs; they touch different lines.
update_package_properties.ymlis not platform-scoped and is unaffected either way.Notes
v0839; renaming it would close and recreate this PR, so it is left as-is.debian/bullseyelegs were already failing onall-citusbefore this change, for an unrelated reason — Bullseye is EOL and itsbullseye-securityInReleasefile is expired, which breaksapt-get updatein the test image. This change simply moves the failure earlier. Either way the fix is #1233 retiring the platform.