connection timeouts and keepalive - #91
Open
james-owen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main knex pool ran queries with no bounds: no statement or query timeout, keepAlive off, and no
acquireConnectionTimeout(thecreateDBIfNotExistsbootstrap client already had one), so a statement that never returns holds a pool connection with nothing to cancel it. Addsstatement_timeout(300s, server-side) andquery_timeout(330s, client-side) to the connection--the server cancels first so the error names the statement that overran--turns onkeepAlive, and gives the pool the sameacquireConnectionTimeoutthe bootstrap client uses. Overridable viaCLAY_STORAGE_STATEMENT_TIMEOUTandCLAY_STORAGE_QUERY_TIMEOUT. Migrations are unaffected--postgres-migrationsgets its own plain connection, not the knex pool. The search-detector's pg client has run against prod with the same 300s statement timeout all week.