Skip to content

Add nightward to Snapshot Tests - #145

Open
JunghyunRyu wants to merge 1 commit into
cleder:mainfrom
JunghyunRyu:patch-1
Open

JunghyunRyu wants to merge 1 commit into
cleder:mainfrom
JunghyunRyu:patch-1

Conversation

@JunghyunRyu

@JunghyunRyu JunghyunRyu commented Oct 24, 2026 •

Copy link
Copy Markdown

Adds nightward, an approval/snapshot-style pytest plugin. It differs from the existing entries in that approval is a separate, review-gated CLI step and one run reports every changed behavior grouped by feature, which is aimed at gating changes made by AI coding agents.

Summary by Sourcery

New Features:

  • Add nightward to the documented list of Python snapshot-testing resources.

@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@sourcery-ai

sourcery-ai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request adds nightward to the README’s snapshot-testing resources, highlighting its pytest/CLI-based, human-approved JSON snapshot workflow for detecting and gating behavior changes.

File-Level Changes

Change Details Files
Documents nightward as an available snapshot-testing resource.
  • Adds a README entry linking to the project repository.
  • Describes its pytest plugin and CLI workflow, including JSON snapshots, human approval, change gating, and feature-grouped behavior reporting.
  • Notes the MIT license.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-code-review

qodo-code-review Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add nightward to Snapshot Tests resources

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Add nightward to the Snapshot Tests section so readers can discover its pytest plugin and CLI.
• Highlight its JSON snapshots, human approval gate, and feature-grouped change reports.
High-Level Assessment

A concise entry in the existing Snapshot Tests section is the appropriate approach; no separate page or structural change is warranted.

Files changed (1) +1 / -0

Documentation (1) +1 / -0
README.mdList nightward under Snapshot Tests +1/-0

List nightward under Snapshot Tests

• Adds a link to nightward alongside other snapshot-testing resources. The entry describes its JSON snapshots, human approval gate, and feature-grouped change reports.

README.md

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@mergify

mergify Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@llamapreview llamapreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LlamaPReview — No blocking issues found

The nightward entry is a single README bullet added to the correct Snapshot Tests section with consistent list style; no code, contract, security, or data path is affected, so the documentation change is safe to merge.

1 non-blocking finding retained — highest: Nightward bullet omits the PR body's stated Python 3.10+ compatibility note.

Review details and evidence
Priority File Finding Evidence
P2 README.md Nightward bullet omits the PR body's stated Python 3.10+ compatibility note. needs verification

Finding details

P2 · Nightward bullet omits the PR body's stated Python 3.10+ compatibility note.

README.md

The author's second acceptance criterion asks the entry to note Python 3.10+ support; the added bullet says "MIT" but not the version. The surrounding Snapshot Tests entries generally omit version notes, so this is a minor completeness gap, not a defect in the listing.

Owner action: Optionally append "Python 3.10+" to the bullet if exact parity with the PR body is desired; this need not happen before merge.

Verification boundary: needs verification; scope: changed region.

Material unknowns

  • The live nightward repository's license and Python-version claims cannot be independently verified from the supplied repository evidence. Does not decide the merge posture; these are author-supplied upstream metadata claims.
    • Check: Optionally confirm the upstream nightward repository's license and minimum Python version if exact parity of external claims matters.

LlamaPReview checks

  • Reviewed changed regions in README.md.
  • Read the complete PR-head file README.md.
  • Read the complete PR-head file .github/workflows/linter.yml.
  • Inspected bounded directory inventory under .github, .gitignore, .pre-commit-config.yaml and 5 more path(s).

LlamaPReview is open source. Explore the code behind this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant